Can't send email in Recover Cart Sales 2.22

[ridexbuilder]

Thanks for the input John.
Well spotted - sometimes can't see the wood for the trees.

<form method=post action=<?php echo $_SERVER['PHP_SELF']; ?>>

This old chestnut - I recall Michael recently saying something about this method. [Memory's fuzzy, so will need to Google the forum].

[JohnW]

Thanks EJ,

Actually, the fine folks at php.net said

<?php echo $PHP_SELF; ?>

should never be present in your code and should be

<?php echo $_SERVER['PHP_SELF']; ?>

so I searched for instances of it and found 4 and replaced them.

I've been trying to get my site error free using E_All error without suppressing E_Notice so any problems with constants defined more than once or not defined pop right up. I've made a lot of progress with it but most changes still only exist in my test sites. It seems most E_NOTICE errors are due to contributions and I noticed Harold is even implementing changes due to E_STRICT which is great to see.

[pgmarshall]

Thanks for this JohnW,

I have subsequently searched my site and found 2 occurances in ...

admin/stats_recover_cart_sales.php
admin/stock.php

JohnW - are there any other global fixes that can be done on the source code?

Hope this helps,

[ridexbuilder]

Thanks John,
I remembered seeing something about it - just was the correct way around. oops!
It's an age thing (must be).

Thanks for clearing it up.

[JohnW]

PG,

Those are the only ones I found on this subject, but there area other things I'm working on. For me, I want to make sure info I pass is good and I have a solution to so I'm trying to learn more first. It's like a big "catch 22" scenario for me.
The more I learn,
the more I know,
the more I see,
the more I realize,
I need to learn more.

[ridexbuilder]

I'm doing a comparison of 2.0.3 svn 176 against RCS 2.30a:

 require(DIR_WS_CLASSES . 'recover_cart_sales.php'); 

appears to be missing in 'Max, along with the relevant file in admin/classes.

Still investigating...

[ridexbuilder]

Might there be a syntax error:

        tep_mail('', $outEmailAddr, EMAIL_TEXT_SUBJECT, $email, '', STORE_OWNER . EMAIL_FROM); 

whereas it looks like this in the working 2.30a

              tep_mail('', $outEmailAddr, EMAIL_TEXT_SUBJECT, $email, STORE_OWNER, EMAIL_FEEDBACK); 

[met00]

Whatever you do, don't ask the guy who created the code as I can hardly recognize my original code in the current stuff... But I will take full responsibility for php_self as that is/was my coding style (I never proceeded it with _SERVER), but then again, this was originally written long before the globals on/off issue became an issue...

[ridexbuilder]

A workaround has been found but it strips out some of the functionality - P.S. for example.
At least mails get sent out.

[michael_s]

I took a closer look at RCS 2.22 and found a very simple fix for the original problem of mail not being sent if register_globals is off.

Simply uncomment line 18 in /admin/recover_cart_sales.php, and mails go out:

link_post_variable('custid'); // fix to allow turning off register_globals in php - does not work w/standard osC (requires some other mod!)