Full service web hosting, great prices and support. Starts at $1.99/month!
Page 2 of 3 First 123 LastLast
Results 11 to 20 of 21

Thread: Can't send email in Recover Cart Sales 2.22

  1. #11
    osCMax Development Team

    Can't send email in Recover Cart Sales 2.22

    ridexbuilder's Avatar
    Join Date
    Jul 2008
    Location
    Haggisland
    Posts
    4,164
    Contribute If you enjoy reading the
    content here, click the below
    image to support our site.
    Click Here To Contribute To Our Site

    Total Contributions For

    ridexbuilder     $ 15.00
    Rep Power
    99


    Thumbs up Re: Can't send email in Recover Cart Sales 2.22

    Thanks for the input John.
    Well spotted - sometimes can't see the wood for the trees.

    PHP Code:
    <form method=post action=<?php echo $_SERVER['PHP_SELF']; ?>>
    This old chestnut - I recall Michael recently saying something about this method. [Memory's fuzzy, so will need to Google the forum].

    Developers resource at bitbucket
    *** *** ***
    oscmax.co.uk / ejsolutions.co.uk
    Hosting plans with installation, configuration, contributions, support and maintenance.
    *** FREE osCmax hosting available ***
    oscmaxtemplates.com

  2. #12
    JohnW
    Guest


    Default Re: Can't send email in Recover Cart Sales 2.22

    Thanks EJ,

    Actually, the fine folks at php.net said
    PHP Code:
    <?php echo $PHP_SELF?>
    should never be present in your code and should be
    PHP Code:
    <?php echo $_SERVER['PHP_SELF']; ?>
    so I searched for instances of it and found 4 and replaced them.

    I've been trying to get my site error free using E_All error without suppressing E_Notice so any problems with constants defined more than once or not defined pop right up. I've made a lot of progress with it but most changes still only exist in my test sites. It seems most E_NOTICE errors are due to contributions and I noticed Harold is even implementing changes due to E_STRICT which is great to see.

  3. #13
    osCMax Development Team

    Can't send email in Recover Cart Sales 2.22

    pgmarshall's Avatar
    Join Date
    Feb 2009
    Location
    London
    Posts
    3,517
    Contribute If you enjoy reading the
    content here, click the below
    image to support our site.
    Click Here To Contribute To Our Site

    Total Contributions For

    pgmarshall     $ 35.00
    Rep Power
    80


    Smile Re: Can't send email in Recover Cart Sales 2.22

    Thanks for this JohnW,

    I have subsequently searched my site and found 2 occurances in ...

    admin/stats_recover_cart_sales.php
    admin/stock.php
    JohnW - are there any other global fixes that can be done on the source code?

    Hope this helps,
    pgmarshall
    _______________________________

  4. #14
    osCMax Development Team

    Can't send email in Recover Cart Sales 2.22

    ridexbuilder's Avatar
    Join Date
    Jul 2008
    Location
    Haggisland
    Posts
    4,164
    Contribute If you enjoy reading the
    content here, click the below
    image to support our site.
    Click Here To Contribute To Our Site

    Total Contributions For

    ridexbuilder     $ 15.00
    Rep Power
    99


    Red face Re: Can't send email in Recover Cart Sales 2.22

    Thanks John,
    I remembered seeing something about it - just was the correct way around. oops!
    It's an age thing (must be).

    Thanks for clearing it up.
    Last edited by ridexbuilder; 10-16-2009 at 10:12 AM.

    Developers resource at bitbucket
    *** *** ***
    oscmax.co.uk / ejsolutions.co.uk
    Hosting plans with installation, configuration, contributions, support and maintenance.
    *** FREE osCmax hosting available ***
    oscmaxtemplates.com

  5. #15
    JohnW
    Guest


    Default Re: Can't send email in Recover Cart Sales 2.22

    PG,

    Those are the only ones I found on this subject, but there area other things I'm working on. For me, I want to make sure info I pass is good and I have a solution to so I'm trying to learn more first. It's like a big "catch 22" scenario for me.
    The more I learn,
    the more I know,
    the more I see,
    the more I realize,
    I need to learn more.

  6. #16
    osCMax Development Team

    Can't send email in Recover Cart Sales 2.22

    ridexbuilder's Avatar
    Join Date
    Jul 2008
    Location
    Haggisland
    Posts
    4,164
    Contribute If you enjoy reading the
    content here, click the below
    image to support our site.
    Click Here To Contribute To Our Site

    Total Contributions For

    ridexbuilder     $ 15.00
    Rep Power
    99


    Post Re: Can't send email in Recover Cart Sales 2.22

    I'm doing a comparison of 2.0.3 svn 176 against RCS 2.30a:
    PHP Code:
     require(DIR_WS_CLASSES 'recover_cart_sales.php'); 
    appears to be missing in 'Max, along with the relevant file in admin/classes.

    Still investigating...



    Developers resource at bitbucket
    *** *** ***
    oscmax.co.uk / ejsolutions.co.uk
    Hosting plans with installation, configuration, contributions, support and maintenance.
    *** FREE osCmax hosting available ***
    oscmaxtemplates.com

  7. #17
    osCMax Development Team

    Can't send email in Recover Cart Sales 2.22

    ridexbuilder's Avatar
    Join Date
    Jul 2008
    Location
    Haggisland
    Posts
    4,164
    Contribute If you enjoy reading the
    content here, click the below
    image to support our site.
    Click Here To Contribute To Our Site

    Total Contributions For

    ridexbuilder     $ 15.00
    Rep Power
    99


    Question Re: Can't send email in Recover Cart Sales 2.22

    Might there be a syntax error:

    PHP Code:
            tep_mail(''$outEmailAddrEMAIL_TEXT_SUBJECT$email''STORE_OWNER EMAIL_FROM); 
    whereas it looks like this in the working 2.30a

    PHP Code:
                  tep_mail(''$outEmailAddrEMAIL_TEXT_SUBJECT$emailSTORE_OWNEREMAIL_FEEDBACK); 

    Developers resource at bitbucket
    *** *** ***
    oscmax.co.uk / ejsolutions.co.uk
    Hosting plans with installation, configuration, contributions, support and maintenance.
    *** FREE osCmax hosting available ***
    oscmaxtemplates.com

  8. #18
    met00
    Guest


    Default Re: Can't send email in Recover Cart Sales 2.22

    Whatever you do, don't ask the guy who created the code as I can hardly recognize my original code in the current stuff... But I will take full responsibility for php_self as that is/was my coding style (I never proceeded it with _SERVER), but then again, this was originally written long before the globals on/off issue became an issue...

  9. #19
    osCMax Development Team

    Can't send email in Recover Cart Sales 2.22

    ridexbuilder's Avatar
    Join Date
    Jul 2008
    Location
    Haggisland
    Posts
    4,164
    Contribute If you enjoy reading the
    content here, click the below
    image to support our site.
    Click Here To Contribute To Our Site

    Total Contributions For

    ridexbuilder     $ 15.00
    Rep Power
    99


    Default Re: Can't send email in Recover Cart Sales 2.22

    A workaround has been found but it strips out some of the functionality - P.S. for example.
    At least mails get sent out.

    Developers resource at bitbucket
    *** *** ***
    oscmax.co.uk / ejsolutions.co.uk
    Hosting plans with installation, configuration, contributions, support and maintenance.
    *** FREE osCmax hosting available ***
    oscmaxtemplates.com

  10. #20
    osCMax Developer


    Can't send email in Recover Cart Sales 2.22


    Join Date
    Jul 2002
    Location
    Phoenix, AZ
    Posts
    23,134
    Contribute If you enjoy reading the
    content here, click the below
    image to support our site.
    Click Here To Contribute To Our Site

    Total Contributions For

    michael_s     $ 10.00
    Rep Power
    597


    Default Re: Can't send email in Recover Cart Sales 2.22

    I took a closer look at RCS 2.22 and found a very simple fix for the original problem of mail not being sent if register_globals is off.

    Simply uncomment line 18 in /admin/recover_cart_sales.php, and mails go out:

    PHP Code:
    link_post_variable('custid'); // fix to allow turning off register_globals in php - does not work w/standard osC (requires some other mod!) 

Page 2 of 3 First 123 LastLast

Similar Threads

  1. Recover Cart Sales
    By michael_s in forum New osCommerce Contributions
    Replies: 0
    Last Post: 04-27-2009, 12:01 PM
  2. Recover Cart Sales
    By michael_s in forum New osCommerce Contributions
    Replies: 0
    Last Post: 04-15-2009, 06:01 PM
  3. Recover Cart Sales
    By michael_s in forum New osCommerce Contributions
    Replies: 0
    Last Post: 04-11-2009, 11:01 PM
  4. Recover Cart Sales
    By michael_s in forum New osCommerce Contributions
    Replies: 0
    Last Post: 04-01-2009, 12:00 PM
  5. Recover Cart Sales
    By michael_s in forum New osCommerce Contributions
    Replies: 0
    Last Post: 10-17-2007, 05:41 PM

Bookmarks

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •