Address Format and Address Line 2 - Suburb (Admin and Catalog issue)

[JRR]

I'm in Canada and the system (2.5.2) has a second line for the addresses that some of my customers use (and my Canada Post application misses!) for things like their apartment number or sometimes there are countries WITH suburbs and they then happily fill it in - if we don't catch this Canada Post won't see it! ...now reading the earlier thread about this topic (Address Format and Address Line 2) from 2011 I see mention where this is a UK/US/AU switch - and I have no idea where this 'switch' is to turn it off.

Seems to me that Suburb should be Address Line 2 in any case, and not dropped as the other thread suggested "Only came to light due to upgrading data, from older releases. Another database table to ignore/convert during upgrades." - addresses can get pretty complicated around the world.

I'm going to edit my CanadaPost php so it accepts this renamed field, but if it is going to be renamed or dropped please let us know!

[JRR]

Digging further I find that admin/shipping_form.php appears to be where the problem may be (lines 164 - 16 -

<tr>
<td class="main" align="left">Address 1:</td>
<td class="main" align="left"><?php echo $order_info['customers_street_address']; ?></td>
<td class="main" align="left"><?php echo tep_draw_input_field('delivery_address1',$order_in fo['delivery_street_address'],'size="30"'); ?></td>
</tr>
<tr>
<td class="main" align="left">Address 2:</td>
<td class="main" align="left"></td>
<td class="main" align="left"><?php echo tep_draw_input_field('delivery_address2','','size= "30"'); ?></td>
</tr>

Note that Address 2: is not defined.

The cure is something like this (admin/shipping_form.php lines 164-16 -

<tr>
<td class="main" align="left">Address 1:</td>
<td class="main" align="left"><?php echo $order_info['customers_street_address']; ?></td>
<td class="main" align="left"><?php echo tep_draw_input_field('delivery_address1',$order_in fo['delivery_street_address'],'size="30"'); ?></td>
</tr>
<tr>
<td class="main" align="left">Address 2:</td>
<td class="main" align="left"><?php echo $order_info['customers_suburb']; ?></td>
<td class="main" align="left"><?php echo tep_draw_input_field('delivery_address2',$order_in fo['delivery_suburb],'','size="30"'); ?></td>
</tr>

I have an artifact in my Canada Post shipping application (/ship_canadapost.php) now where the second address line in "Shipping Address" says (in red) "* Required" however the application appears to ignore that 'requirement' and will continue on to send the data to Canada Post.
However the 'suburb' is now there if the customer filled it in so I am happy.

Not sure if this belongs in the bug report unless others using applications different from Canada Post run into it.

[JRR]

Digging further I find that admin/shipping_form.php appears to be where the problem may be (lines 164 - 168 ):

<tr>
<td class="main" align="left">Address 1:</td>
<td class="main" align="left"><?php echo $order_info['customers_street_address']; ?></td>
<td class="main" align="left"><?php echo tep_draw_input_field('delivery_address1',$order_in fo['delivery_street_address'],'size="30"'); ?></td>
</tr>
<tr>
<td class="main" align="left">Address 2:</td>
<td class="main" align="left"></td>
<td class="main" align="left"><?php echo tep_draw_input_field('delivery_address2','','size= "30"'); ?></td>
</tr>

Note that Address 2: is not defined.

The cure is something like this (admin/shipping_form.php lines 164-168 ):

<tr>
<td class="main" align="left">Address 1:</td>
<td class="main" align="left"><?php echo $order_info['customers_street_address']; ?></td>
<td class="main" align="left"><?php echo tep_draw_input_field('delivery_address1',$order_in fo['delivery_street_address'],'size="30"'); ?></td>
</tr>
<tr>
<td class="main" align="left">Address 2:</td>
<td class="main" align="left"><?php echo $order_info['customers_suburb']; ?></td>
<td class="main" align="left"><?php echo tep_draw_input_field('delivery_address2',$order_in fo['delivery_suburb],'','size="30"'); ?></td>
</tr>

I have an artifact in my Canada Post shipping application (/ship_canadapost.php) now where the second address line in "Shipping Address" says (in red) "* Required" however the application appears to ignore that 'requirement' and will continue on to send the data to Canada Post.
However the 'suburb' is now there if the customer filled it in so I am happy.

Not sure if this belongs in the bug report unless others using applications different from Canada Post run into it.