Address Format and Address Line 2

[ridexbuilder]

Rant warning!!!

Background.
I've been putting together a 2.5 RC1 (well, SVN 1502 actually) development site in conjunction with a client. It's a "sister" site to currently running 2.0.25 and so many of the products and other settings were copied over from it.

Contrary to my usual way of working the visuals (template) is near completion, if not completed and functional testing is underway. A couple of dummy orders are placed on the system...

What's this? The suburb is now called Address Line 2 (can live with that) but is flamin' duplicated. Strange!
Go check the database entries in Address Book and Orders - nope they're fine. Time to trace the code then...
Literally, after hours, I finally discovered what's going on.

[Now, I'm sure this has changed for some flimsy legitimate reason, like Google Checkout or Fedex shipping, or something.]

Rather than the suburb line simply being checked for an entry, it is now concatenated, along with a "cr" or "br", to the end of the Street (Address Line 1). Loads of knock-on effect, including emails. Why did it rear its' ugly head in this particular situation? Well the address_format database table was already set for what was the correct UK format of ...$street$cr$suburb... so with an easy change using phpmyadmin it now reads ...$streets...
Easy, when you know how & why.

Go figure!

Change for good is, well good; change for the sake of it, is well... ((insert suitable word)).
Another couple of days wasted, when my few grey cells should be thinking about something else.

EJ

[Back to thinking about Multi-store (beta stage), YMM (RC stage) and T-shirt Designer (infancy stage)]

[pgmarshall]

EJ - I don't see where this is ...

Just turned on Suburb (Address Line 2) and it goes in the dbase fine ... where is it coming out wrong? In the address format or in other stuff?

Hope it wasn't me that changed anything! Address Line 2 might be my fault (or is this UK/US Switch sensitive) ... goes off to check.

Regards.

Ps. The address line 2 is controlled by the UK/US/AUS switch.

[ridexbuilder]

One example; there may be others:
Line 528 of general.php

    if ($suburb != '') $streets = $street . $cr . $suburb; 

[pgmarshall]

But that has been there since r143 (and probably before)! Doesn't look right I agree but it has been there for ever!!

Diff of general.php r151 - oscmax2 - osCmax - osCommerce Maximized - Google Project Hosting

Regards.

[ridexbuilder]

Only came to light due to upgrading data, from older releases. Another database table to ignore/convert during upgrades.

Looks like you're off the hook, this time, PGM.

[pgmarshall]

PHEW! Thats a relief ...