banner manager not uploading image

[MrE03]

The banner manager for some reason isn't uploading the images into images/banner. I set the permission at 755 and also tried 777.

[pgmarshall]

You need to give us more information ... "It isn't working for me" ... does not help us ascertain the issue.

Regards,

[MrE03]

Well I'm not sure how else I can really explain it because, I wanted to see if I'm the only person having this problem.

I would pretty much go to banner manager:

Insert all the information and click browse to upload an image. After I click submit there's a highlighted green bar on top that says, Success: banner has been inserted. However when I check my images/banner folder in ftp, it did not upload the image. I'm just trying to determine if anyone else is having this issue or if they're able to upload banners without any problems. I've uploaded many banners before with previous versions so at this point I'm just seeing if it's a bug or it's just some kind of mistake I'm making and overseeing. Apologize for being vague

[pgmarshall]

It looks like a bug to me ... just tested on a test store ... image not going to the banners sub-folder but rather into the images/ folder.

This is because we have been trying to tidy up the images folder ... post a bug report linking to this thread and I will fix it ...

If you want to fix it now ...

Line 61 in banner_manager.php

$banners_image->set_destination(DIR_FS_CATALOG_IMAGES . $banners_image_target);

Should be

$banners_image->set_destination(DIR_FS_CATALOG_IMAGES . 'banners/' . $banners_image_target);

Regards,

[pgmarshall]

Bug Fixed: r1412 - oscmax2 - osCmax - osCommerce Maximized - Google Project Hosting

Regards,

[lamontef]

I just did the same fix earlier today on the Affiliate banner manager... Over the years I've had a lot of experience with custom ad tracking systems, so there are a few specific wants and wishlist items as it relates to the Affiliate tracking system I'd like to see and will be working on. I've spent the last few days working through a number of issues in the Affiliate code and would like to contribute the code/ideas for what I'm doing if it's of interest to the development team.

LaMonte Forthun

[pgmarshall]

I've spent the last few days working through a number of issues in the Affiliate code and would like to contribute the code/ideas for what I'm doing if it's of interest to the development team.

We would be delighted if you would like to help contribute ... The bugtracker is probably the best place to report bug fixes or code improvements.

But if you prefer you can simply post them here with a short explanation and the developers will review and commit for you.

Thank you for offering to contribute to the community.

Regards,

[lamontef]

Probably the best way to move forward on this one is to give you or whomever what I've come up with instead of me trashing the bug tracker... I'll try to figure out a good way to break things down and move forward and then I'll figure out or ask for help with the bug tracker system.

LaMonte

[MrE03]

cool thanks for looking into this PGMarshall!

[blackhawk]

very cool!!! Looking forward to this!